Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete huge input files of realization exogenousof module 31_fossil #1504

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

LaviniaBaumstark
Copy link
Member

Purpose of this PR

delete huge input files of realization exogenousof module 31_fossil, get rid of huge files

Type of change

  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@fbenke-pik
Copy link
Contributor

Thanks, can you also lower the threshold for sizes in the check as well?

maxfilesize(600)

@LaviniaBaumstark LaviniaBaumstark merged commit 0e3c126 into remindmodel:develop Dec 8, 2023
2 checks passed
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

  1. How about an issue in mrremind to incorporate these files (assigned to Nico)?
  2. How about
     *** |  Contact: [email protected]
     *** SOF ./modules/31_fossil/exogenous/datainput.gms
    
    +$abort "fossil/exogenous dysfunctional until input data required by mrremind";
     p31_fix_costfu_ex(tall,regi,enty) = 0;
     *** $include "./modules/31_fossil/exogenous/input/p31_fix_costfu_ex.put";  
     p31_fix_fuelex(tall,regi,enty,rlf) = 0;
    ?

Because in this state, the realisation will run at zero fossil extraction costs, without any indication to the user.
Come to think of it: did it run at all? Might as well just delete it an have @nicobauer restore it from the git history should he really want to fix it.

$ git checkout v3.2.1.dev500 -- modules/31_fossil/exogenous/

@LaviniaBaumstark
Copy link
Member Author

I agree, deleting would have been the better solution, @nicobauer did want to keep it. Those input files are created when running the realization "timeDepGrades" of the module and is nothing which should/could be generated by `mrremind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants