-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing columns cm_implicitQttyTarget, cm_emiMktTarget, cm_altFeEmiFac to DeepEl scenario config #1462
base: develop
Are you sure you want to change the base?
Conversation
…miFac to DeepEl scenario config
bump @cchrisgong |
thanks, Michaja! sorry for the delay. These switches look like they are EU specific targets? Should they be in all Deep_El which is a global scenario? Are they legally bound targets? maybe they should be in a separate deepEl_eur config? |
These are switches introduced into the default scenarios in |
Lavinia said config.csv should be always aligned with main.gms. These switches she is not aware of. I believe their values in scenario_config.csv and in main.gms are not the same (so two different "default"). Would like to know if we need to change it where, or how to move forward with this PR |
|
In main.gms $setGlobal cm_implicitQttyTarget off !! def = off |
can this PR be closed? |
still thinks cm_implicitQttyTarget in the config csv should be default and not contain EU switches.. @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q ? |
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly