Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Tech|*|Capital Costs|w/ Adj Costs to reference run #1429

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Oct 12, 2023

Purpose of this PR

  • fix Tech|*|Capital Costs|w/ Adj Costs on reference run
  • for t <= cm_startyear, the paramater o_avgAdjCostInv was just 0 which caused remind2::reportTechnology to forget about adjustment costs. See longer problem description here: https://github.com/remindmodel/development_issues/issues/226
  • I did not run a full remind to check whether that fixes it, as the error seems obvious and I checked that the variables used to calculate the output parameter remain unchanged between fulldata.gdx and input_ref.gdx, so that must work :)

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters merged commit 6354ec1 into remindmodel:develop Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants