Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow runs to reference runs of the same name (i.e. earlier versions of themselve) for the path_gdx #1426

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

close #1423

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • thanks for testing it
  • One remark: If you pushed a config file using that to the repo, it will fail make test-full for others later on this test, because it cannot find the path_gdx
  • I suggest catching this case here replacing those lines by:
          if (path_to_gdx == "path_gdx" && iscenarios[iscen, path_to_gdx] == iscen) {
            iscenarios[iscen, path_to_gdx] <- NA
          } else {
            icfg$errorsfoundInConfigureCfg <- sum(icfg$errorsfoundInConfigureCfg, 1)
            message(red, "Error", NC, ": Can't find a gdx specified as '", iscenarios[iscen, path_to_gdx], "' in column ",
                    path_to_gdx, ".\nPlease specify full path to gdx or name of output subfolder that contains a ",
                    "fulldata.gdx from a previous normally completed run.")
          }

@orichters
Copy link
Contributor

I would probably like to use that for the next round of NGFS runs. If you agree with my suggestion above, could we merge this PR, @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q?

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q merged commit f94b000 into remindmodel:develop Feb 5, 2024
2 checks passed
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q deleted the dev/self_reference_gdx branch February 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow self-referencing path_gdx to restart failed runs?
2 participants