make sure lower bound on vm_cesIO is at least the offset_quantity, to prevent negative net energy consumption #1404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net
vm_cesIO
(i.e.vm_cesIO + pm_cesdata("offset_quantity")
, the latter being negative) was not limited at zero on thepf
level, only on thepf
-sum. Specifically, while the sum of all hydrogen net consumption in industry would be 0 in 2010 (so equal production of 0), individual industry subsectors would consume morefeh2_
than indicated by their offset quantity (and others less), resulting in (very small) negative net consumption, which showed up when looking into a industry reporting issue (#1399).I extended this to all lower bounds on
vm_cesIO
. Other modules probably are not affected, but this was faster then checking all production factors individually.Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):
/p/tmp/pehl/Remind/output/SSP2EU-Base_2023-09-07_11.37.01
/p/tmp/pehl/Remind/compScen-2023-09-11_12.42.07-H12.pdf