Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count failing regions correctly #1397

Merged
merged 1 commit into from
Sep 11, 2023
Merged

count failing regions correctly #1397

merged 1 commit into from
Sep 11, 2023

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • the scripts was aborting after the first region that reached the fail limit was found
  • so you could end up thinking one region failed while it were multiple
  • now, count them correctly, then print the current status, and fail then

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • All automated model tests pass (FAIL 0 in the output of make test)

@orichters orichters merged commit a0e4e79 into remindmodel:develop Sep 11, 2023
1 check passed
@orichters orichters deleted the improvefails branch December 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renato-Rodrigues Renato-Rodrigues Renato-Rodrigues approved these changes

@PhilippVerpoort PhilippVerpoort Awaiting requested review from PhilippVerpoort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orichters @Renato-Rodrigues