Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in start_bundle_coupled fail on missing files/dirs #1382

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Aug 21, 2023

Purpose of this PR

  • If you somehow misspecified the files / folders, start_bundle_coupled broke quite late with unclear message. Rather fail early.
  • in output.R, if no folder contains gdx files (and mif if needed), fail and tell the user instead of printing this nonsense:
Please choose runs to be used for output generation:

1,a: all
2,p: Search pattern by regular expression...
3,f: Search by fixed pattern...

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test-coupled-slurm)

@orichters orichters merged commit 77b1f5a into remindmodel:develop Sep 1, 2023
1 check passed
@orichters orichters deleted the errorcounting branch December 6, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants