Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow gamscompile to get input data, update regexp in main.gms #1368

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • make sure --gamscompile also adjusts the sets and also input data if required, to make sure also H21 runs can be checked and tests can be extended
  • I moved updateSets() into its own function and created updateInputData() which will then be called by prepare.R
  • call these functions also from runGamsCompile
  • some additions to regexp tests as introduced in reactive check_config, add regexp check for cfg$… values #1356
  • unfortunately, I had to take out some more files out of the compilation tests because some scenarios fail to compile now. But we can fix that later --> configs that fail start.R --gamscompile #1367

Type of change

  • Refactoring
  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • All automated model tests pass (FAIL 0 in the output of make test and make test-full)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters requested review from dklein-pik and removed request for fbenke-pik August 25, 2023 09:18
start.R Show resolved Hide resolved
@LaviniaBaumstark
Copy link
Member

I like splitting out the functions updateSets() and updateInputData()

@orichters orichters merged commit 3f5054e into remindmodel:develop Sep 11, 2023
1 check passed
@orichters orichters deleted the smallfix4 branch January 31, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants