-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if input_bau.gdx is given or really needed; a couple of minor changes mostly related to MAgPIE coupling #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortings are generated.
…s start SSPEU-NPi in priority
…d with start.R --test
…) in more places.
orichters
approved these changes
Jul 26, 2023
7 tasks
6 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR contains a couple of minor changes to R scripts mostly related to REMIND-MAgPIE coupling (code cleaning, adding comments, ...).
The most important change and not related to coupling is a new check in
checkFixCfg.R
that throws an error if an NDC is to be started but noinput_bau.gdx
was given. In case no NDC is to be calculated but aninput_bau.gdx
is provided it will be set to NA since it would otherwise introduce an unnecessary dependency to the preceeding BAU run. This is most relevant for the parallel mode of coupled runs, where in each iteration the unnecessary dependency may prevent the start of subseqent runs if the preceeding BAU run (that is actually not required in a non-NDC scenario) fails.Type of change
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctly