Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if input_bau.gdx is given or really needed; a couple of minor changes mostly related to MAgPIE coupling #1366

Merged
merged 11 commits into from
Jul 26, 2023

Conversation

dklein-pik
Copy link
Contributor

@dklein-pik dklein-pik commented Jul 25, 2023

Purpose of this PR

This PR contains a couple of minor changes to R scripts mostly related to REMIND-MAgPIE coupling (code cleaning, adding comments, ...).

The most important change and not related to coupling is a new check in checkFixCfg.R that throws an error if an NDC is to be started but no input_bau.gdx was given. In case no NDC is to be calculated but an input_bau.gdx is provided it will be set to NA since it would otherwise introduce an unnecessary dependency to the preceeding BAU run. This is most relevant for the parallel mode of coupled runs, where in each iteration the unnecessary dependency may prevent the start of subseqent runs if the preceeding BAU run (that is actually not required in a non-NDC scenario) fails.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@dklein-pik dklein-pik marked this pull request as ready for review July 26, 2023 12:25
scripts/start/checkFixCfg.R Outdated Show resolved Hide resolved
scripts/start/checkFixCfg.R Show resolved Hide resolved
tests/testthat/test_01-checkFixCfg.R Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants