Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR6 climate assessment on postprocessing #1318

Merged

Conversation

gabriel-abrahao
Copy link
Contributor

Purpose of this PR

This is meant only as an emergency draft, since some people seem to be needing this quite urgently. Probably none of this will be done this way when we merge.

This is the bare minimum needed to run the AR6 climate assessment, with the updated MAGICC version and probabilistic ensemble, in the postprocessing of a set of REMIND scenarios. We will progressively move towards having this inside GAMS and run every iteration, but right now it only works at postprocessing.

It works on the output xlsx of output.R -> export -> xlsx_IIASA -> AR6. To use, run that first, then cd to scripts/utils/climate_assessment. There, replace filename in submit_climate_assessment.sh with the output of the above (should be in output/export/REMIND_xxxx_.xlsx). Then submit it to slurm using:

sbatch submit_climate_assessment.sh

The output will be in a subfolder called output_climate. All variables plus some metadata, including the AR6 classification of each scenario, will be in a file with the alloutput.xlsx prefix, but there are others with just more specific data.

You might want to cherry pick this @bs538 @merfort

Type of change

  • [ x] New feature

Checklist:

@merfort
Copy link
Contributor

merfort commented May 24, 2023

Thanks a lot, Gabriel!
I will check it out.

@gabriel-abrahao
Copy link
Contributor Author

@LaviniaBaumstark would you mind taking a look at this? It's definitely a work in progress, but it would be nice to have your input on whether this should be done in scripts or should be incorporated into a reporting library or something. The latter would mean having some Python mixed in the libraries, which might not be desirable. I can also think of an approach using bash scripts.

@LaviniaBaumstark
Copy link
Member

Thanks Gabriel. I thing, for now it is o.k. having it as scripts as part of the output.R world, no need to transfer this to our reporting packages. The climate assessment will anyway we a separate calculation and I thing you describe a comfortable way for REMIND users interested in this specific analysis.

@gabriel-abrahao gabriel-abrahao marked this pull request as ready for review August 10, 2023 13:27
@gabriel-abrahao
Copy link
Contributor Author

Thanks Gabriel. I thing, for now it is o.k. having it as scripts as part of the output.R world, no need to transfer this to our reporting packages. The climate assessment will anyway we a separate calculation and I thing you describe a comfortable way for REMIND users interested in this specific analysis.

Thanks! I marked it as ready for review then

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took Gabriel's branch, installed it and we fixed all (permission) errors that showed up. The result looks promising. You just have to make sure to add the location python is installed to your PATH in order for it to work.

@LaviniaBaumstark
Copy link
Member

what is the status of this PR? will you continue working on it?

@gabriel-abrahao
Copy link
Contributor Author

what is the status of this PR? will you continue working on it?

Sorry, I thought this was merged already. I addressed Michaja's point now, please go ahead and merge.

@LaviniaBaumstark
Copy link
Member

@gabriel-abrahao could you please take care of merging after all tests are passed and @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q agrees

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine from my side, added a small suggestion for improvement

@gabriel-abrahao
Copy link
Contributor Author

@gabriel-abrahao could you please take care of merging after all tests are passed and @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q agrees

Sure, just waiting for Michaja then.

@gabriel-abrahao
Copy link
Contributor Author

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q would you mind taking a look later? I removed the .bashrc reference

@gabriel-abrahao gabriel-abrahao merged commit 7870f26 into remindmodel:develop Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants