Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deltaCap time split for vm_capCum #1258

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

tabeado
Copy link
Contributor

@tabeado tabeado commented Mar 17, 2023

Purpose of this PR

Follow up on the removal of the deltaCap time split implemented by Robert (PR #1238). q_capCumNet and the calculation of p22_marginalCapcumBenefit are adjusted to be consistent with the new implementation of deltaCap.

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

  • Bug fix
  • Refactoring
  • New feature
  • Minor change (default scenarios show only small differences)
  • Fundamental change
  • This change requires a documentation update

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here: /p/tmp/tabeado/deltaCapCleanup/remind/output
  • Comparison of results (what changes by this PR?):

@tabeado
Copy link
Contributor Author

tabeado commented Apr 6, 2023

The effects appear to be generally very small. The main exception are prices for hydrogen (see e.g. p.92 & p. 115 in /p/tmp/tabeado/deltaCapCleanup/remind/output/compScen-fullComp-2023-04-06_08.43.12-H12.pdf

@cchrisgong
Copy link
Contributor

cchrisgong commented Apr 6, 2023

Our H2 price is kind of weird - it was being discussed in mattermost but not resolved (?)
SE H2 price collapses under NDC for SSA and for EUR - probably just because we are using old calibration? I.e. calibration would have "constant" demand, and H2 supply is lower in NDC run, so price collapses... if there is a short compscen (plot until 2050) then one can see it clearer probably..
image

@tabeado
Copy link
Contributor Author

tabeado commented Apr 6, 2023

Chris, I added the short compareScenarios2: P:\deltaCapCleanup\remind\output\compScen-FullCompShort-2023-04-06_11.05.22-H12-short

@LaviniaBaumstark
Copy link
Member

what is the status of this PR? will you continue working on it?

@cchrisgong
Copy link
Contributor

there are small but visible changes: more VRE capacity under baseline, and more electricity under 1.5C
/p/tmp/tabeado/deltaCapCleanup/remind/output

image

image

This looks reasonable to me, as usually deltacap(T+1) is larger than deltacap(T) for VRE in the first half of the century, so when this changes involve cumulative capacity going from .5* deltacap(T+1) + 0.5* deltacap(T) to deltacap(T+1), it will increase wind and solar deployment because they are learned faster based on higher cumulative capacities. This will decrease electricity price under 1.5C to increase electrification

@tabeado tabeado marked this pull request as ready for review January 12, 2024 13:22
@tabeado tabeado merged commit 2646a08 into remindmodel:develop Jan 12, 2024
2 checks passed
@tabeado tabeado deleted the deltaCap_for_capCum branch January 12, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants