Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDR cleaning session #1154

Merged
merged 12 commits into from
Nov 24, 2023
1 change: 0 additions & 1 deletion core/declarations.gms
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ v_co2capturevalve(ttot,all_regi) "CO2 emitted right a
vm_prodUe(ttot,all_regi,all_enty,all_enty,all_te) "Useful energy production [TWa]"

vm_capEarlyReti(tall,all_regi,all_te) "fraction of early retired capital"
vm_otherFEdemand(ttot,all_regi,all_enty) "final energy demand from no transformation technologies (e.g. enhanced weathering)"

vm_demSeOth(ttot,all_regi,all_enty,all_te) "other sety demand from certain technologies, have to calculated in additional equations [TWa]"
vm_prodSeOth(ttot,all_regi,all_enty,all_te) "other sety production from certain technologies, have to be calculated in additional equations [TWa]"
Expand Down
1 change: 0 additions & 1 deletion core/sets.gms
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ $ENDIF.WindOff
apCarElT "Cars using final energy electricity (FEELT) to produce useful energy as electricity for transport (UEELT)"
apTrnElT "Trains using final energy electricity (FEELT) to produce useful energy as electricity for transport (UEELT)"
*** appCarGaT "Cars using FEGAT to produce ESGAT." ???
rockgrind "grinding rock for enhanced weathering" !! deprecated, will be removed with CDR module refactoring
weathering "enhanced weathering"
dac "direct air capture"
x_gas2elec
Expand Down
17 changes: 12 additions & 5 deletions main.gms
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,8 @@ $setglobal fossil grades2poly !! def = grades2poly
$setglobal power IntC !! def = IntC
*'--------------------- 33_CDR ----------------------------------------
*'
*' * (off) : no carbon dioxide removal technologies except BECCS
*' * (weathering) : includes enhanced weathering
*' * (DAC) : includes direct air capture
*' * (all) : includes all CDR technologies
$setglobal CDR DAC !! def = DAC
*' * (portfolio) : CDR options added via switches: cm_33[option abbreviation]
$setglobal CDR portfolio !! def = portfolio
*'--------------------- 35_transport ----------------------------------------
*'
*' * (complex): transport realization with aggregated transport demand (LDV, HDV, electric trains) via CES function with constrained choice on vehicle technologies
Expand Down Expand Up @@ -847,6 +844,16 @@ parameter
*' * (0): no import, the default starting value as specified in modules/ 0 /on/input/tax_CO2.inc, core/input/data_emibudget.inc, modules/15_climate/box/datainput.gms is used
*' * (1): the values from the gdx are read in (works only if the gdx has a parameter value) ATTENTION: make sure that the values from the gdx have the right structure (e.g. regionally differentiated or not)
*'
parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have all these parameters in one "section" here. Would it make sense to rename others also to cm_33*** to indicate that they are only used in module 33, e.g. cm_33gs_ew, cm_33LimRock? Or would this be against our coding etiquette? And what do you think about assembling also other relevant switches here, like cm_frac_CCS, cm_frac_NetNegEmi, c_ccsinjecratescen, c_ccscapratescen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree with cm_33gs_ew, cm_33LimRock, as they're only used in the CDR module. However, I will change it in a separate PR. When it comes to cm_frac_CCS, cm_frac_NetNegEmi, c_ccsinjecratescen, c_ccscapratescen, since these are used in the core, I'd keep them as they are, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, agree to keep the names for those. It would be nice to have them all in one place close together, but this can be done in a separate PR

cm_33DAC "choose whether DAC (direct air capture) should be included into the CDR portfolio. 0 = DAC not used, 1 = used"
;
cm_33DAC = 1; !! def = 1
*'
parameter
cm_33EW "choose whether EW (enhanced weathering) should be included into the CDR portfolio. 0 = EW not used, 1 = used"
;
cm_33EW = 0; !! def = 0
*'
parameter
cm_gs_ew "grain size (for enhanced weathering, CDR module) [micrometre]"
;
Expand Down
18 changes: 0 additions & 18 deletions modules/33_CDR/DAC/bounds.gms

This file was deleted.

21 changes: 0 additions & 21 deletions modules/33_CDR/DAC/datainput.gms

This file was deleted.

35 changes: 0 additions & 35 deletions modules/33_CDR/DAC/declarations.gms

This file was deleted.

88 changes: 0 additions & 88 deletions modules/33_CDR/DAC/equations.gms

This file was deleted.

11 changes: 0 additions & 11 deletions modules/33_CDR/DAC/not_used.txt

This file was deleted.

20 changes: 0 additions & 20 deletions modules/33_CDR/DAC/realization.gms

This file was deleted.

45 changes: 0 additions & 45 deletions modules/33_CDR/DAC/sets.gms

This file was deleted.

17 changes: 0 additions & 17 deletions modules/33_CDR/all/bounds.gms

This file was deleted.

42 changes: 0 additions & 42 deletions modules/33_CDR/all/datainput.gms

This file was deleted.

Loading