Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix code demo #569

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

Rezmason
Copy link
Contributor

Created an advanced demo, using floating point FBOs, GPU compute, MSDFs, a bloom implementation, and noisy color mapping to recreate the code rain effect seen in The Matrix.

This is a simplified version of the project I maintain separately, and recently migrated to REGL.

…Fs, a bloom implementation, and noisy color mapping to recreate the code rain effect seen in The Matrix.

Added thumbnail to example/img.
Comment on lines +63 to +67
#exList li {
list-style-type: disc;
margin-left: 1em;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding support for bulleted lists in example descriptions

Comment on lines 331 to 341
fs.writeFile('www/gallery.html', html)
fs.writeFile('www/gallery.html', html, function(err){
if (err) {
throw err
}
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node threw an error, actually, when I first ran the gallery builder, because there was no passed in handler.

Comment on lines +407 to +409
console.log('minified ', minFile)
console.log('stdout: ', stdOut)
console.log('stderr: ', stdErr)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outputting this data before attempting to save the file, in case there was a full-blown error that prevented the minified file from being generated in the first place

@rreusser
Copy link
Member

rreusser commented May 30, 2020

Thanks for this, @Rezmason! Looks great. The built-in gallery had a dependency on wzrd.in which didn't reliably work, so I think https://github.com/regl-project/regl-gallery is a more promising place to maintain the gallery (additionally, the gallery link on regl.party has been redirected to https://regl-project.github.io/regl/www/gallery.html ).

At risk of stepping on toes, I've never maintained the gallery, so I took the liberty of transferring this PR over and rebuilding the gallery: regl-project/regl-gallery#1 It can be nice to distribute small examples with the npm module for easy offline reference, but it's probably additionally a good idea to remove the build scripts from the regl repo to prevent confusion over where the gallery actually lives (pardon the duplication!)

@Rezmason
Copy link
Contributor Author

Sounds good! Removing the redundancy sounds like a good call.

@mikolalysenko
Copy link
Collaborator

I still think we can land this.

@mikolalysenko mikolalysenko merged commit ddb0e88 into regl-project:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants