Skip to content

Commit

Permalink
fix: cipherSuitesTLS13 linked to crypto/tls
Browse files Browse the repository at this point in the history
This mislinkage caused the program to misbehave, since we are modifying the available ciphersuites to manipulate the selection.

Signed-off-by: Gaukas Wang <[email protected]>
  • Loading branch information
gaukas committed May 2, 2024
1 parent b248750 commit fe984af
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/go_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@

name: "Go Build"

on: [push, pull_request]
# on: [push, pull_request]
on: push # no need to double-run on PR if we are running on all pushes already

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion internal/qtls/cipher_suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
tls "github.com/refraction-networking/utls"
)

//go:linkname cipherSuitesTLS13 crypto/tls.cipherSuitesTLS13
//go:linkname cipherSuitesTLS13 github.com/refraction-networking/utls.cipherSuitesTLS13
var cipherSuitesTLS13 []unsafe.Pointer

//go:linkname defaultCipherSuitesTLS13 crypto/tls.defaultCipherSuitesTLS13
Expand Down

0 comments on commit fe984af

Please sign in to comment.