Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Splices repo + GHCJS splices #787

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

cidkidnix
Copy link
Contributor

@cidkidnix cidkidnix commented Jun 29, 2022

TODO:
Switch splices-load-save.nix to a thunk

Depends on #788

@cidkidnix
Copy link
Contributor Author

To note the diffs will be pretty much useless until I make a new branch after I've disabled nixpkgs-fmt in my editor!

default.nix Outdated
Comment on lines 3 to 6
, config ? {
android_sdk.accept_license = true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only do this in release.nix on purpose, as we cannot opt into the license on behalf of our users.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add some sort of comment so this is clear to the next person to edit this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, leftover from local testing.

@Ericson2314
Copy link
Member

To note the diffs will be pretty much useless until I make a new branch after I've disabled nixpkgs-fmt in my editor!

Yes any mass formatting changes should always be done in a separate PR, if at all.

@cidkidnix cidkidnix force-pushed the dylang/external-splices-loading-nix branch from d77247a to 4452db0 Compare June 30, 2022 11:54
@cidkidnix cidkidnix force-pushed the dylang/external-splices-loading-nix branch from 4452db0 to 7712970 Compare June 30, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants