Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to the CI script #55

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

odr
Copy link

@odr odr commented Jun 8, 2024

No description provided.

@Ericson2314
Copy link
Member

Partly rendered obsolete by #56, but not entirely.

Ericson2314 added a commit that referenced this pull request Sep 12, 2024
1. Restore a `Data.Semigroup.Commutative` reexport accidentally removed
   in #56. (I accidentally forgot to notice during review.)

2. Replace partial `Map.lookup` with proper custom error for internal
   error. (This would make debugging a bug in the implementation
   easier.) This was part of #55.

Co-Authoredy-By: Dmitry Olshansky <[email protected]>
@Ericson2314
Copy link
Member

Rebased, now just CI changes

@Ericson2314 Ericson2314 changed the title build with 9.10.1. Clean warnings and upd CI Some changes to the CI script Sep 26, 2024
@@ -13,32 +13,52 @@ jobs:

name: GHC ${{ matrix.ghc }} on ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: haskell/actions/setup@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haskell/actions

OK yes that repo is deprecated, I just learned. This helps me understand why these changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main goal was compiling with javascript-backend. I think that #56 do it so I am OK to close...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants