-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove console-testing-library
#4603
Open
aryaemami59
wants to merge
22
commits into
reduxjs:master
Choose a base branch
from
aryaemami59:remove-console-testing-library
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove console-testing-library
#4603
aryaemami59
wants to merge
22
commits into
reduxjs:master
from
aryaemami59:remove-console-testing-library
+689
−712
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 16dbf6b - Browse repository at this point
Copy the full SHA 16dbf6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f1ca19 - Browse repository at this point
Copy the full SHA 8f1ca19View commit details -
Configuration menu - View commit details
-
Copy full SHA for a628cfd - Browse repository at this point
Copy the full SHA a628cfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d6f8e7 - Browse repository at this point
Copy the full SHA 0d6f8e7View commit details -
Fix issues related to
console
spies in `serializableStateInvariantM……iddleware.test.ts`
Configuration menu - View commit details
-
Copy full SHA for 99cb3c1 - Browse repository at this point
Copy the full SHA 99cb3c1View commit details -
Fix issues related to
console
spies in `immutableStateInvariantMidd……leware.test.ts`
Configuration menu - View commit details
-
Copy full SHA for 8f4754d - Browse repository at this point
Copy the full SHA 8f4754dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67d9bf0 - Browse repository at this point
Copy the full SHA 67d9bf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08cfbe4 - Browse repository at this point
Copy the full SHA 08cfbe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ecba7b - Browse repository at this point
Copy the full SHA 4ecba7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bfb16a - Browse repository at this point
Copy the full SHA 2bfb16aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad905da - Browse repository at this point
Copy the full SHA ad905daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ffa35d - Browse repository at this point
Copy the full SHA 7ffa35dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15748ce - Browse repository at this point
Copy the full SHA 15748ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for caef8e0 - Browse repository at this point
Copy the full SHA caef8e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7de16ef - Browse repository at this point
Copy the full SHA 7de16efView commit details -
Fix issue with
console
spy insidebuildHooks.test.tsx
- `.mockReset()` should not be called in spies since it calls `.mockClear()` and returns the implementation to its **initial** form. In this case it was silencing some of the `act` related warnings emitted by `@testing-library/react` which needed to be resolved since they were calling issues. So `.mockReset()` calls on spies need to be changed to `.mockRestore()` calls since `.mockRestore()` restores the implementation to its **original** form.
Configuration menu - View commit details
-
Copy full SHA for 4e94fcb - Browse repository at this point
Copy the full SHA 4e94fcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2ce575 - Browse repository at this point
Copy the full SHA b2ce575View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b6baff - Browse repository at this point
Copy the full SHA 3b6baffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e898c5 - Browse repository at this point
Copy the full SHA 7e898c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for efe78bd - Browse repository at this point
Copy the full SHA efe78bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b606b96 - Browse repository at this point
Copy the full SHA b606b96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e6368f - Browse repository at this point
Copy the full SHA 6e6368fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.