Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledgment of Configuration Updates in Watcher Mode. #91 #95

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tirth7545
Copy link

Desciption

  • Benthos supports watcher mode, but currently there is no acknowledgment when the configuration is successfully reloaded. To address this, an API needs to be introduced that provides the count of successful configuration updates while running in watcher mode.

Acceptance Criteria

  • Introduce an API endpoint that provides the count of successful configuration reloads, applicable only in watcher mode.

API Reference

Get Succss reload count

 GET  /benthos/config/ack

Response Body

{
   "success_reload_count": "1"
}
Parameter Type Description
success_reload_count string Success Config Reload Count

Github Issue : #91

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@Tirth7545
Copy link
Author

Hi, @mihaitodor could you please review this ?

@@ -62,6 +62,7 @@ func New(
wholeConf any,
log log.Modular,
stats metrics.Type,
count *int,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than slowly adding more parameters here it might be worth replacing wholeConf with an abstraction that allows these other peices of information to be accessed, which we can expand over time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants