Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2230928: api: removing dependency on hardcoded value when onboarding consumer #36

Closed
wants to merge 1 commit into from

Conversation

rchikatw
Copy link
Contributor

@rchikatw rchikatw commented Oct 9, 2023

when onboarding a new consumer using API parameters are changed the same change needs to be implement here. Now no longer need to pass the hard coded value while onboarding a consumer.

when onboarding a new consumer using API parameters are changed
the same change needs to be implement here. Now no longer need
to pass the hard coded value while onboarding a consumer.

Signed-off-by: rchikatw <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

@rchikatw: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

api: removing dependency on hardcoded value when onboarding consumer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rchikatw

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rchikatw
Copy link
Contributor Author

rchikatw commented Oct 9, 2023

@Madhu-1 Madhu-1 changed the title api: removing dependency on hardcoded value when onboarding consumer BUG 2230928: api: removing dependency on hardcoded value when onboarding consumer Oct 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

@rchikatw: This pull request references Bugzilla bug 2230928, which is invalid:

  • expected the bug to target the "ODF 4.13.4" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BUG 2230928: api: removing dependency on hardcoded value when onboarding consumer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Oct 9, 2023

@rchikatw This BZ is not having the right version set, This PR cannot be merged until the BZ is targeting for right version

@rchikatw
Copy link
Contributor Author

closing this PR As we discontinue FaaS development and in the current situation, customers would not see provider/consumer support for 4.12/4.13 so this backport is not needed. Hence Closing the bug.

@rchikatw rchikatw closed this Oct 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

@rchikatw: An error was encountered removing this pull request from the external tracker bugs for bug 2230928 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

BUG 2230928: api: removing dependency on hardcoded value when onboarding consumer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants