erratum: stash json to enable get_erratum_data() #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktdreyer
approved these changes
Apr 22, 2019
lhh
reviewed
Apr 22, 2019
| @@ -211,6 +212,7 @@ def _fetch(self, errata_id): | |||
| # NEW_FILES QE etc. | |||
| self.errata_state = erratum['status'] | |||
| self._original_state = self.errata_state | |||
| self._original_json = erratum | |||
There was a problem hiding this comment.
This is only capturing the API/v1 content. The old style errata content is not here. It's entirely fine if that's what you need, but I just wanted to make a note of that.
There was a problem hiding this comment.
There are a few fields that are not in the API/v1 content; see line 270-ish.
|
this partially addresses issue #156 |
|
I've added docs and tests in #160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.