Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php70] Fix delimiter in the middle on EregToPregMatchRector #6356

Merged
merged 1 commit into from
Oct 5, 2024
Merged

[Php70] Fix delimiter in the middle on EregToPregMatchRector #6356

merged 1 commit into from
Oct 5, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 5, 2024 •
edited
Loading

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @corentin-larose

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 3d76a1a into main Oct 5, 2024
36 checks passed
@samsonasik samsonasik deleted the handle-delimiter-middle branch October 5, 2024 18:02
@samsonasik
Copy link
Member Author

@corentin-larose please try latest "rector/rector": "dev-main" and verify if it works and no regression ;)

@samsonasik samsonasik mentioned this pull request Oct 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EregToPcreTransformer won't work when string contains preg delimiter
1 participant
@samsonasik