New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeDeclaration] Better approach for native type check ParametersAcceptors on ReturnStrictTypeAnalyzer #6343

Merged

samsonasik merged 1 commit into main from better-approach-check-native

Oct 1, 2024

Member

samsonasik commented Oct 1, 2024

@TomasVotruba continue of PR:

Around PHPStan 1.12.4+ handling on ParametersAcceptors with non-native return type (by docblock) #6341

I found that this is better approach to check on NativeFunctionReflection early.


          [TypeDeclaration] Better approach for native type check on ReturnStri…

cb878e4

…ctTypeAnalyzer

Member Author

samsonasik commented Oct 1, 2024

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

samsonasik merged commit d17d3e8 into main

36 checks passed

samsonasik deleted the better-approach-check-native branch

October 1, 2024 13:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet