Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Add isset(), empty(), and negation support on BoolReturnTypeFromBooleanStrictReturnsRector #6339

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

samsonasik
Copy link
Member

It not exists yet in any type declaration set

https://getrector.com/demo/47045075-aa6d-4fc0-bd68-86cfbd048677

I add it to BoolReturnTypeFromBooleanStrictReturnsRector for this PR.

@samsonasik
Copy link
Member Author

implemented 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 54a6620 into main Oct 1, 2024
36 checks passed
@samsonasik samsonasik deleted the add-isset-empty-negation branch October 1, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant