clean

rectorphp · Aug 22, 2024 · 9708f61 · 9708f61
1 parent 7968c05
commit 9708f61
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/rules/Php84/Rector/Param/ExplicitNullableParamTypeRector.php b/rules/Php84/Rector/Param/ExplicitNullableParamTypeRector.php
@@ -70,6 +70,15 @@ public function refactor(Node $node): ?Param
             return null;
         }
 
+        $newNodeType = TypeCombinator::addNull($nodeType);
+        $paramType = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($newNodeType, TypeKind::PARAM);
+
+        // ensure it process valid Node, otherwise, just return null
+        if ($paramType === null) {
+            return null;
+        }
+
+        // re-use existing node instead of reprint Node that may cause unnecessary FQCN
         if ($node->type instanceof UnionType) {
             $node->type->types[] = new ConstFetch(new Name('null'));
         } else {