use double quote to escape quotes in EncapsedStringsToSprintfRector

rectorphp · Sep 23, 2024 · 807e7ed · 807e7ed
1 parent a99b50d
commit 807e7ed
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/...Style/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/translation_function.php.inc b/...Style/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/translation_function.php.inc
@@ -25,4 +25,3 @@ final class TranslationFunction
 }
 
 ?>
-
diff --git a/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php b/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php
@@ -64,7 +64,7 @@ public function configure(array $configuration): void
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Convert enscaped {$string} to more readable sprintf or concat, if no mask is used',
+            'Convert enscaped {$string} to more readable sprintf or concat, if no value is used',
             [
                 new ConfiguredCodeSample(
                     <<<'CODE_SAMPLE'
@@ -204,7 +204,9 @@ private function createSprintfFuncCallOrConcat(string $mask, array $argumentVari
             return null;
         }
 
-        $arguments = [new Arg(new String_($mask))];
+        $string = $this->createString($mask);
+
+        $arguments = [new Arg($string)];
         foreach ($argumentVariables as $argumentVariable) {
             $arguments[] = new Arg($argumentVariable);
         }
@@ -239,4 +241,13 @@ private function createSingleValueEdgeConcat(array $argumentVariables, string $m
 
         return null;
     }
+
+    private function createString(string $value): String_
+    {
+        $kind = str_contains($value, '\'') ? String_::KIND_DOUBLE_QUOTED : String_::KIND_SINGLE_QUOTED;
+
+        return new String_($value, [
+            'kind' => $kind,
+        ]);
+    }
 }