[CodingStyle] Use double quote to escape quotes in EncapsedStringsToS…

…printfRector (#6326) * add test fixture for rectorphp/rector#8838 * use double quote to escape quotes in EncapsedStringsToSprintfRector * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <[email protected]>
rectorphp · Sep 23, 2024 · 398b04d · 398b04d
1 parent 5170018
commit 398b04d
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/...Style/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/translation_function.php.inc b/...Style/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/translation_function.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\Encapsed\EncapsedStringsToSprintfRector\Fixture;
+
+final class TranslationFunction
+{
+    public function run(string $pattern)
+    {
+        echo _("My translatable text with '{$pattern}'.");
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\Encapsed\EncapsedStringsToSprintfRector\Fixture;
+
+final class TranslationFunction
+{
+    public function run(string $pattern)
+    {
+        echo _(sprintf("My translatable text with '%s'.", $pattern));
+    }
+}
+
+?>
diff --git a/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php b/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php
@@ -204,7 +204,9 @@ private function createSprintfFuncCallOrConcat(string $mask, array $argumentVari
             return null;
         }
 
-        $arguments = [new Arg(new String_($mask))];
+        $string = $this->createString($mask);
+
+        $arguments = [new Arg($string)];
         foreach ($argumentVariables as $argumentVariable) {
             $arguments[] = new Arg($argumentVariable);
         }
@@ -239,4 +241,13 @@ private function createSingleValueEdgeConcat(array $argumentVariables, string $m
 
         return null;
     }
+
+    private function createString(string $value): String_
+    {
+        $kind = str_contains($value, "'") ? String_::KIND_DOUBLE_QUOTED : String_::KIND_SINGLE_QUOTED;
+
+        return new String_($value, [
+            'kind' => $kind,
+        ]);
+    }
 }