Fixes

rectorphp · Oct 6, 2024 · 0c2de7c · 0c2de7c
1 parent 5c77c9c
commit 0c2de7c
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/...s/TypeDeclaration/Rector/FunctionLike/AddClosureParamTypeFromIterableMethodCallRector.php b/...s/TypeDeclaration/Rector/FunctionLike/AddClosureParamTypeFromIterableMethodCallRector.php
@@ -90,13 +90,13 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $varType = $this->getType($node->var);
-
-        if (! $varType instanceof IntersectionType || ! $varType->isIterable()->yes()) {
+        if ($node->isFirstClassCallable()) {
             return null;
         }
 
-        if ($node->isFirstClassCallable()) {
+        $varType = $this->getType($node->var);
+
+        if (! $varType instanceof IntersectionType || ! $varType->isIterable()->yes()) {
             return null;
         }
 
@@ -145,9 +145,11 @@ public function refactor(Node $node): ?Node
             if (! $arg instanceof Arg) {
                 continue;
             }
+
             if (! $arg->value instanceof Closure) {
                 continue;
             }
+
             $parameter = (is_string($index) ? $parameters[$nameIndex[$index]] : $parameters[$index]);
 
             if ($this->updateClosureWithTypes($className, $parameter, $arg->value, $keyType, $valueType)) {
@@ -214,6 +216,11 @@ private function refactorParameter(Param $param, Type $type): bool
         }
 
         $paramTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($type, TypeKind::PARAM);
+
+        if (! $paramTypeNode instanceof Node) {
+            return false;
+        }
+
         $param->type = $paramTypeNode;
 
         return true;