Big cookbook refactoring #101
Conversation
|
I will try to pull this branch down today and take a look. Thanks for working on this. |
libraries/provider_service.rb
Outdated
| kb_user = find_kb_resource(run_context, :kibana_user, new_resource) | ||
| # Create service | ||
| # | ||
| if kb_install.version == 'tarball' |
|
https://github.com/realityforge/chef-kibana/pull/101/files#diff-5bae58210cebc9fc0b3fdd3c12b3a3b9R25 When install version 5.x kibana, command is blank. |
add to_s for kb_install.type condition
|
@isaoshimizu Which command is blank? Can you show me line please. |
|
@cyberflow templates/default/upstart.conf.erb Line 22 |
|
👍 |
- enable kibana 5 tarball install to pull from the correct repo location - make the service template configurable & use the attributes already created - allow redhat and centos installs to configure the kibana service - add a CentOS/RHEL 6 init.d service template. - add unit/integration tests for nginx and kibana5
attributes/default.rb
Outdated
| @@ -126,7 +72,7 @@ | |||
| default['kibana']['nginx']['server_name'] = 'kibana' | |||
|
|
|||
| #<> The nginx configuration source | |||
| default['kibana']['nginx']['source'] = node['kibana']['version'] == '4' ? 'nginx4.conf.erb' : 'nginx.conf.erb' | |||
| default['kibana']['nginx']['source'] = node['kibana']['version'] == '4' ? 'nginx4.conf.erb' : 'nginx5.conf.erb' | |||
There was a problem hiding this comment.
Probably need to make this conditional test a regex (=~ /^4/) to match all 4.x versions
libraries/provider_install.rb
Outdated
| action :nothing | ||
| end | ||
| pkg_r.run_action(:install) | ||
| new_resource.updated_by_last_action(true) if pkg_r.updated_by_last_action? |
There was a problem hiding this comment.
Using install_type = package will cause the kibana package to upgrade to the latest version in the repository instead of the one specified in node[kibana][version]. Thoughts on adding version determine_version(new_resource, node) to this package resource?
|
Hi @cyberflow, I'm lending a hand with maintaining this repo and I'd like to revive your PR and get it mergeable again. Are you available/interested to rebase this branch by chance? |
|
I'd like to break this up and land separately:
|
Remove deprecated compact resource and matchers
add support for centos/rhel installs
Remove deprecated chef_nginx cookbook to enable Chef 13+ usage
remove deprecated supports manage_home
|
Hi @mburns |
It's try to rewrite cookbook to Chef resources. It's tested for 5.x but can be use for install 4.x as well. I think that we can deprecated 3.x versions for now. Please review it.