Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAPPS-DB] Add Realtek multiple audio drivers #278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

julenuri
Copy link
Collaborator

@julenuri julenuri commented Oct 12, 2024

All of them (realtek hd and ac97) are partially compatible to our code, and will fasten up the testing in case that the user wants to test them.

With few tweaks the thing works nicely.

AC97: Tweak quoted under CORE-18238
HDAUD: Tweak quoted under CORE-17310

Examples: Portcls.sys from windows 2003 https://www.youtube.com/watch?v=EsU7WNkpuF8
And
https://www.youtube.com/watch?v=-NukhxCScic with some hdaudbus tweaks.

I hope this will speedup our tests. 💯

@JoachimHenze
Copy link
Contributor

Please add more details into the PRs description about the "few tweaks" that are currently still necessary to make them work.

Icon = realtek.ico

[Section.amd64]
URLDownload = https://akacc.net/win98/0001-WDM_A406.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do link the same exe for x86 and x64, which makes me think this is most likely an x86 binary. Sure, it might contain both versions of the driver, but if the exe runs only on x86 due to missing WOW64, then wouldn't it be wise to strip the amd64-block here entirely? Same question for RealtekHD.txt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW64 is something that will be in the next... # days, but the first thing I need is to have the drivers. It could be .zip files, but .exe can be also extracted with 7zip, so it's ok.
This version contains both x86 and x64 drivers for Windows 2003 (32 and 64 bits). I know that they might not be the most functional ones... But they are interesting.

Copy link
Contributor

@JoachimHenze JoachimHenze Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stuff that you would just add to the [SECTION] but not in the [Section.amd64] wouldn't be downloadable at all in the ros x64 build? (then I would understand what you did with the duplication)

Name = Realtek HD Audio Drivers R2.74 (WDM)
Version = R2.74 (5.10.0.7111)
License = Propietary
Description = Realtek HD Audio codec and drivers, suitable for multiple soundcards/chipsets and devices as workstation, laptops, minipc, etc.
Copy link
Contributor

@JoachimHenze JoachimHenze Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional suggestion. Notice the part with the EOL-whitespace-stripping. That part is mandatory.

Suggested change
Description = Realtek HD Audio codec and drivers, suitable for multiple soundcards/chipsets and devices as workstation, laptops, minipc, etc.
Description = Realtek HD Audio codec and drivers, suitable for multiple soundcards/chipsets.

Category = 13
URLSite = https://www.realtek.com/
URLDownload = https://ftp.nluug.nl/pub/games/PC/guru3d/realtek/WDM_R274-[Guru3D.com].exe
SHA1 = 1a7835cedecab8c1e25789d73a696925184d54f2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best is to strip them all via the NPP-feature

Suggested change
SHA1 = 1a7835cedecab8c1e25789d73a696925184d54f2
SHA1 = 1a7835cedecab8c1e25789d73a696925184d54f2


[Section.amd64]
URLDownload = https://ftp.nluug.nl/pub/games/PC/guru3d/realtek/WDM_R274-[Guru3D.com].exe
SHA1 = 1a7835cedecab8c1e25789d73a696925184d54f2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SHA1 = 1a7835cedecab8c1e25789d73a696925184d54f2
SHA1 = 1a7835cedecab8c1e25789d73a696925184d54f2

Name = Realtek Audio Drivers for AC97 A4.06
Version = A4.06 (5.10.0.6300)
License = Propietary
Description = Audio driver for Win2000/WinME/WinXP (WDM driver) for multiple AC97 cards like ALC850, ALC655 or ALC250. Suitable for multiple old workstation systems with VIA or C-media chipsets.
Copy link
Contributor

@JoachimHenze JoachimHenze Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are mentioning WinME here. Why not mentioning Win98 then as well?

Suggested change
Description = Audio driver for Win2000/WinME/WinXP (WDM driver) for multiple AC97 cards like ALC850, ALC655 or ALC250. Suitable for multiple old workstation systems with VIA or C-media chipsets.
Description = Audio driver for Win98/WinME/Win2000/WinXP (WDM driver) for multiple AC97 cards like ALC850, ALC655 or ALC250. Suitable for multiple old systems with VIA or C-media chipsets.

Copy link

@fiatcoupe16vturbo fiatcoupe16vturbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add turkish description
use that
[Section.041f]
Description =

@learn-more
Copy link
Member

please add turkish description use that [Section.041f] Description =

  1. You did not actually include the text
  2. The owner of the PR is free to ignore requests like this, because the burder of translating does not fall on whoever works on a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants