Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project abandoned? #1129

Closed
pioz opened this issue Jun 10, 2021 · 23 comments
Closed

Is this project abandoned? #1129

pioz opened this issue Jun 10, 2021 · 23 comments

Comments

@pioz
Copy link

pioz commented Jun 10, 2021

I see that the latest commit is from a year ago and the React version used by this gem is v16 when React 18 is about to come out. So my question is: is this gem still maintained and active?

🥺

@BookOfGreg
Copy link
Member

BookOfGreg commented Jun 16, 2021

Yes and no.
This gem works for me, and over time I added more maintainers, and they fixed their issues and it works for them too.
Broadly speaking this gem still does all versions of React (though we don't bother bundling new versions with Sprockets since Webpack won) and does HMR and SSR and those fun tricks with some minor tweaks out of the box.

If you have a particular feature you'd like to add or a pet-bug you want to squash, then generally speaking if you have a good github history then I'll let you in. That goes for everyone reading this, if you have a good track record and either want to (A) Help others, or even (B) Just fix it for your own project / workplace / personal glory, then welcome aboard!

@justin808
Copy link
Collaborator

@pioz and @BookOfGreg, my team is available to help. I have invested in the React + Rails ecosystem since my 2014 article about the subject. Most recently. we're maintaining and developing https://github.com/shakacode/shakapacker, the official successor to webpacker.

@BookOfGreg if you'd like help, let me know!

@BookOfGreg
Copy link
Member

Hi Justin, cool that you have taken over from Webpacker, I'd have thought you'd integrate react-on-rails into that?

@justin808
Copy link
Collaborator

Hi Greg! Integrate react-on-rails into which project?

Shakapacker/Webpacker should work fine with react-rails.

Right now, Shakapacker has no direct connections to any frontend framework.

We're even making babel optional, with swc being support shakacode/shakapacker#29.

@paul-mesnilgrente
Copy link

Any chances to get a new release? I need this PR but I'd like pointing the gem to "master" =/ ?

@BookOfGreg
Copy link
Member

@paul-mesnilgrente I'd love to. What I'm most interested in at the moment is finding a group of interested people that I can help grow into the next group of maintainers on this project. I'm currently doing the same with RSwag which has also recently been resurrected.
Would you have an interest in helping validate if the current master build is safe and bug free so we can launch it with confidence?
I've reached out to a couple interested parties as well to try get some effort going on this repo.

@paul-mesnilgrente
Copy link

I'll ask my company if they can give me some time on this :)

@son1112
Copy link

son1112 commented Mar 17, 2022

@BookOfGreg I am interested in helping to validate if the current master build is safe and bug free so we can launch it with confidence. 🥳

@BookOfGreg
Copy link
Member

@son1112 good to hear, has anyone had the chance to test it out lately?

@BookOfGreg
Copy link
Member

And same to you @paul-mesnilgrente, any luck with your company? If it's in use with them then happy to have contributions from someone with sponsored time.

@swrobel
Copy link

swrobel commented May 10, 2022

@justin808 any chance you're still willing to step in here? Your team has done such an amazing job with shakapacker!

@justin808
Copy link
Collaborator

justin808 commented May 11, 2022

I've been waiting for the official go-ahead! My team is growing, and we'd love to help out.

@BookOfGreg, and others, maybe we can meet up for a zoom call sometime?

How about you all jump on my slack, and I'll create a channel for react-rails.

Here's the invite: Slack discussion channel.

image

@BookOfGreg
Copy link
Member

@swrobel I'm still looking for other maintainers than Justin, I've not been impressed by the description of what his vision for this gem is yet. I'm hoping that others will step forward instead.
Justin if your fork becomes successful then I'd have to reasonably hand over the project.

@justin808
Copy link
Collaborator

justin808 commented May 14, 2022

Hi @BookOfGreg, can you point me to where I made such a description for a vision?

In terms of maintenance, there's work to be done to ensure good releases from the community.

Maybe you can use what I did with Webpacker to Shakapacker as an example?

  1. Clean up all the old issues and PRs. I touched on every single issue and PR in the Webpacker. Issues touched by justin808, PRs touched by justin808
  2. Release, with a good changelog
  3. Participate in slack, issue, and PR discussions

And take a look at the flow of activity on https://github.com/shakacode/shakapacker

Besides me, I'd contribute my staff's time to make sure this happens.

We could all jump on zoom to discuss sometime.

How's that sound?

@justin808
Copy link
Collaborator

@BookOfGreg @swrobel what's the next step?

@swrobel
Copy link

swrobel commented May 28, 2022

@BookOfGreg I think it's awesome that Justin is stoked to take over this project. Even if he didn't already have an incredible track record, he is the only one putting his hand up.

@justin808
Copy link
Collaborator

@BookOfGreg Any updates?

If I get the green light, my team and I will:

  1. Go through every issue and triage them.
  2. Triage all the current PRs.

Based on those, we'll know what the next steps are.

@swrobel any additional ideas?

@swrobel
Copy link

swrobel commented Jul 12, 2022

@justin808 I wish I had some influence here, but it seems it's all in @BookOfGreg's hands. While he has expressed openness in the past, it seems that his 👎🏼 to my last comment indicates his opinion may have changed, although he hasn't commented on anything here recently...

@rmosolgo I hate to drag you into this, but is there any chance you have any influence here?

@justin808
Copy link
Collaborator

@rmosolgo and my team have worked closely on challenging graphql-ruby pro issues! I'll reach out to him.

Consider:

  1. ShakaCode has a solid reputation for maintaining open-source related to Rails, React, and webpack, in addition to many Rust and ReScript projects. For sure, we want to keep that reputation.
  2. ShakaCode has been doing open-source management since 2014 and plans to continue doing this for the foreseeable future. This is lower risk and excellent stability than having any individual take over.
  3. Having ShakaCode maintain the project will result in all pull requests and issues getting triaged and frequent releases. Just look at the changelogs for Shakapacker and React on Rails for example.

Will ShakaCode create some significant new features for react-rails? Probably not soon, given the backlog of issues and PRs to triage.

I encourage @BookOfGreg to voice his objections here.

@justin808
Copy link
Collaborator

Bump... @BookOfGreg have you had a chance to look at this?

I've got a growing engineering team that can help with the maintenance.

For example, check out the PRs that we've done regarding React 18.

Given that we're maintaining Shakapacker and React on Rails, we should have the right experience to get this project back on track.

@BookOfGreg
Copy link
Member

@justin808 I've granted you access as a member.
The best way for you to prove me wrong is to do a good job.

@justin808
Copy link
Collaborator

Hi @BookOfGreg, awesome to hear. My team at ShakaCode will start to help.

To be completely transparent, ShakaCode.com invests company resources to maintain open source projects for several reasons:

  1. We enjoy it. Seriously.
  2. Our consulting clients use these open-source projects.
  3. Our open source projects have helped us connect with awesome clients over many years as a consulting company.

So working on open source is both a hobby and a job for the Shakacode team.

@hibachrach
Copy link
Contributor

While I'm not able to commit to anything in particular, I've spent a lot of time reading over react-rails's source code and would be happy to help out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants