Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7 support #1162

Closed
JensDebergh opened this issue Feb 15, 2022 · 9 comments
Closed

Rails 7 support #1162

JensDebergh opened this issue Feb 15, 2022 · 9 comments

Comments

@JensDebergh
Copy link

Hi

I was wondering if there are any plans to upgrade react-rails to rails 7.0.

I would like to update my application to the newest version but I am stuck due to react-rails dependency on 6.1.x

Kind regards
Jens

@BookOfGreg
Copy link
Member

My apologies, support has been merged into master, I'm currently trying to drum up additional maintainers to help ensure that releases are properly supported.
If you use this at your work, can you please consider asking for open-source volunteer time to help support projects like this one?
See also:
#1129 (comment)

@reactjs reactjs deleted a comment from justin808 Aug 8, 2022
@reactjs reactjs deleted a comment from justin808 Aug 8, 2022
@justin808
Copy link
Collaborator

@BookOfGreg what's a good test app to try this with Rails 7?

I posted this issue: BookOfGreg/react-rails-example-app#57

@hdpuk86
Copy link

hdpuk86 commented Aug 9, 2022

Does this gem work with Rails 7 and if so, can you update the README's instructions with info about Rails 7? It seems unclear to me whether it does and how to make it work if so.

I have it working with Rails 7 & Webpacker. Following the instructions in the README for rails versions < 6.0 should also work with rails 7. If you don't want to be using Webpacker then I'm not sure but maybe this will help someone.

I had to replace:

## application.html.erb
<%= javascript_importmap_tags %>

with:

## application.html.erb
<%= javascript_pack_tag 'application' %>

@justin808
Copy link
Collaborator

@hdpuk86 If you can submit a PR, I'll promptly review and merge.

@alkesh26
Copy link
Collaborator

alkesh26 commented Oct 7, 2022

@hdpuk86, Can you please raise a PR for this?

@thadeu
Copy link

thadeu commented Nov 18, 2022

+1

@ahangarha
Copy link
Collaborator

@justin808 Should I work on this?

@ahangarha
Copy link
Collaborator

I want to confirm if we need anything to do other than add instructions to the documentation.

@justin808
Copy link
Collaborator

was fixed a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants