Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency materialdesignthemes.mahapps to v3 #182

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 3, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
MaterialDesignThemes.MahApps 0.3.0 -> 3.1.0 age adoption passing confidence

Release Notes

MaterialDesignInXAML/MaterialDesignInXamlToolkit (MaterialDesignThemes.MahApps)

v3.1.0: Version 3.1.0

ComboBox visual change:

Previously the popup box tried to determine its background color by looking up the visual tree. However this is not always possible (see #​1550). The fix (#​1576) was to switch it to use the theme brush. If you are not using the MaterialDesignPaper theme brush for the control that contains the ComboBox it should just work for you. If you are not doing that, you will notice that the background of your ComobBox drop down is no longer the same color. You can work around this by setting the MaterialDesignPaper resource brush at a reasonable level. Something like:

<ComboBox>
    <ComboBox.Resources>
        <SolidColorBrush x:Key="MaterialDesignPaper" Color="Red" />
    </ComboBox.Resources>
...
</ComboBox>

You can also move that brush up to the Window level resources if it makes sense in your application, rather than specifying it on each ComboBox. Alternatively if you use the same background for all combo boxes you can use this style in your App.xaml

<Style TargetType="ComboBox" BasedOn="{StaticResource {x:Type ComboBox}}">
    <Style.Resources>
        <SolidColorBrush x:Key="MaterialDesignPaper" Color="Red" />
    </Style.Resources>
</Style>

A big thank you to everyone who contributed (either logging issues or submitting PRs):
@​AgPeHaJIuH1
@​ahmedflix25
@​ahmediddma
@​alekstrust
@​AmRo045
@​andybond006
@​awebre
@​bebenins
@​bukshuk
@​burekas7
@​ColossalMoose
@​ContainsK
@​dmuehlenhoff
@​FooPenguin
@​Gopichandar
@​greuelpirat
@​IamJapanese
@​jespersh
@​Jesus805
@​kodaniel
@​kvpt
@​LiptonOlolo
@​mgnslndh
@​MichelMichels
@​mipen
@​mr-at0s
@​Mrxx99
@​NZSmartie
@​paulovila
@​pavka1799
@​philpowers
@​punker76
@​raimand13
@​schorsch2489
@​schulz3000
@​soi013
@​Taschenbuch
@​Wolfteam
@​w-syss
@​xthehacker2000x
@​yangbocheng
@​yosefmah


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/materialdesignthemes.mahapps-3.x branch 7 times, most recently from 7075444 to b0c0a3c Compare July 3, 2024 20:29
@renovate renovate bot force-pushed the renovate/materialdesignthemes.mahapps-3.x branch from b0c0a3c to 5b916f6 Compare July 3, 2024 20:30
@ChrisPulman ChrisPulman merged commit 9125b7d into main Jul 3, 2024
1 check passed
@ChrisPulman ChrisPulman deleted the renovate/materialdesignthemes.mahapps-3.x branch July 3, 2024 20:30
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant