-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worked on generating proper link #63
base: next
Are you sure you want to change the base?
Worked on generating proper link #63
Conversation
@@ -386,7 +386,8 @@ function getSchemaShape(moduleJson = {}, json = {}, schemas = {}, name = '', opt | |||
} | |||
else { | |||
// grab the type for the non-array schema, so we get the link for free | |||
let type = getSchemaType(module, json.items, schemas, {code: options.code, link: options.link, title: options.title}) | |||
// added asPath and baseUrl to generate proper URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this have to do with asPath
and baseUrl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're saying those get passed in and used by getSchemaType
because they are part of the options
hash, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes .
added asPath and baseUrl to generate proper URL.