fix: CPP Enum/AnyOf (#210)

* fix: Safe name issue reverted from javascript * fix: Adjust anyOf templates for events * fix: Make anyOf templates strings * fix: Revert debug change * fix: Add enum changes into this branch * fix: Remove unneeded changes --------- Co-authored-by: Shah, Kevin <[email protected]> Co-authored-by: kschri201_comcast <[email protected]>
rdkcentral · Aug 30, 2024 · eb768fb · eb768fb
1 parent 665aad3
commit eb768fb
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 7 deletions.
diff --git a/languages/cpp/templates/callback-initialization/anyOf.cpp b/languages/cpp/templates/callback-initialization/anyOf.cpp
@@ -1 +1 @@
-{property};
+            std::string ${property};
diff --git a/languages/cpp/templates/callback-result-instantiation/anyOf.cpp b/languages/cpp/templates/callback-result-instantiation/anyOf.cpp
@@ -1 +1 @@
-         ${property};
+            ${property} = proxyResponse->Value();
diff --git a/languages/cpp/templates/json-types/anyOf.h b/languages/cpp/templates/json-types/anyOf.h
@@ -1 +1 @@
-WPEFramework::Core::JSON::VariantContainer
+FireboltSDK::JSON::String
diff --git a/languages/cpp/templates/json-types/property-assign.cpp b/languages/cpp/templates/json-types/property-assign.cpp
@@ -1,2 +1,2 @@
-            Add(_T("${property}"), &${Property});
+            Add(_T("${property.raw}"), &${Property});
             ${Property} = other.${Property};
diff --git a/languages/cpp/templates/json-types/property-register.cpp b/languages/cpp/templates/json-types/property-register.cpp
@@ -1 +1 @@
-            Add(_T("${property}"), &${Property});
+            Add(_T("${property.raw}"), &${Property});
diff --git a/src/macrofier/types.mjs b/src/macrofier/types.mjs
@@ -17,7 +17,7 @@
  */
 
 import deepmerge from 'deepmerge'
-import { getPath, localizeDependencies, getSafeEnumKeyName } from '../shared/json-schema.mjs'
+import { getPath, localizeDependencies, getSafeEnumKeyName, getSafeKeyName } from '../shared/json-schema.mjs'
 import path from "path"
 import { getConfig } from '../shared/configLoader.mjs'
 
@@ -318,7 +318,7 @@ const insertObjectPatternPropertiesMacros = (content, schema, module, title, opt
 
 const getIndents = level => level ? '    ' : ''
 const wrapProp = name => name.match(/[/\.\+]/) ? `"${name}"` : name
-const safePropName = name => config.enableStringPropertyKeys ? wrapProp(name) : getSafeEnumKeyName(name)
+const safePropName = name => config.enableStringPropertyKeys ? wrapProp(name) : getSafeKeyName(name)
 const insertObjectMacros = (content, schema, module, title, property, options) => {
   const options2 = options ? JSON.parse(JSON.stringify(options)) : {}
   options2.parent = title
@@ -350,6 +350,8 @@ const insertObjectMacros = (content, schema, module, title, property, options) =
           const description = getSchemaDescription(prop, module)
           let replacedTemplate  = template
           .replace(/(^\s+)/g, '$1'.repeat(options2.level))
+          .replace(/\$\{property.raw\}/g, name) //Gives the raw RPC propery name, even if it's unsafe
+          .replace(/\$\{Property.raw\}/g, capitalize(name))
           .replace(/\$\{property\}/g, safePropName(name))
           .replace(/\$\{Property\}/g, capitalize(safePropName(name)))
           .replace(/\$\{parent\.title\}/g, title)

diff --git a/src/shared/json-schema.mjs b/src/shared/json-schema.mjs
@@ -520,6 +520,10 @@ function mergeOneOf(schema) {
   return union(schema.oneOf)
 }
 
+const getSafeKeyName = (value) => value.split(':').pop()
+                                        .replace(/[\.\-]/g, '_')                       // replace dots and dashes
+                                        .replace(/\+/g, '_plus')                       // change + to _plus
+
 const getSafeEnumKeyName = (value) => value.split(':').pop()                           // use last portion of urn:style:values
                                         .replace(/[\.\-]/g, '_')                       // replace dots and dashes
                                         .replace(/\+/g, '_plus')                       // change + to _plus
@@ -529,6 +533,7 @@ const getSafeEnumKeyName = (value) => value.split(':').pop()
 
 export {
   getSchemaConstraints,
+  getSafeKeyName,
   getSafeEnumKeyName,
   getExternalSchemaPaths,
   getLocalSchemas,