Audio descriptions + closed captions -> jq rules #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
brendanobra
changed the title
| @@ -204,6 +209,12 @@ impl BrokerOutput { | |||
| } | |||
| None | |||
| } | |||
| pub fn is_success(&self) -> bool { | |||
| self.data.error.is_none() | |||
There was a problem hiding this comment.
Is it better to validate the result field here ?
| self.data.error.is_none() | ||
| } | ||
| pub fn is_failure(&self) -> bool { | ||
| !self.is_success() |
There was a problem hiding this comment.
Similar comment, if error field has some value, then data contains error response.
| } | ||
| None => None, | ||
| }; | ||
| } else if raw_value.get("success").is_some() { |
There was a problem hiding this comment.
This needs to be re-checked for result and error use cases.
result response struct is implementation defined and success field is not part of standard JSON-RPC 2.0 response format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist