Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthru with mock #423

Open
wants to merge 88 commits into
base: main
Choose a base branch
from
Open

Passthru with mock #423

wants to merge 88 commits into from

Conversation

satlead
Copy link
Collaborator

@satlead satlead commented Feb 14, 2024

What

Add Provider Brokerage support for HTTP, Websocket and Thunder endpoints
Add Device Mock extensions to allow development without device and thunder dependencies
New Open RPC file with HDMI support

Why

Ripple is migrating to a Gateway to use a provider pattern with Thunder and Cloud brokers. This change enables Ripple to leverage brokers instead of requiring to implement the RPC handlers in Ripple or in Extensions

How

The first example used for this implementation is HDMI. We support HDMIINput.open, HDMIInput.close and HDMIInput.onAutoLowLatencyModeSignalChanged

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/423/rdkcentral/Ripple

  • Commit: ffbe320

Report detail: gist

@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

  • Protex Server Path: /home/blackduck/github/Ripple/423/rdkcentral/Ripple

  • Commit: ffbe320

Report detail: gist

@rdkcmf-jenkins
Copy link

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Not a problem

  • Commit: ffbe320

@satlead satlead marked this pull request as ready for review February 15, 2024 19:10
Copy link

github-actions bot commented Feb 16, 2024

Code Coverage

Package Line Rate Health
core.sdk.src.extn 54%
core.sdk.src.extn.client 87%
core.sdk.src.extn.ffi 46%
core.main.src.bootstrap.extn 0%
core.main.src.service.apps 31%
core.sdk.src.api.distributor 87%
device.thunder_ripple_sdk.src.client 14%
distributor.general.src 2%
core.tdk.src.utils 0%
device.thunder_ripple_sdk.src 14%
core.sdk.src.framework 71%
core.launcher.src 1%
core.main.src.utils 12%
core.sdk.src.api.manifest 42%
device.thunder_ripple_sdk.src.processors 4%
core.tdk.src 100%
device.thunder.src 2%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.service.extn 30%
core.main.src.state.cap 44%
core.sdk.src.api.device 57%
core.main.src.bootstrap 0%
core.sdk.src.utils 54%
core.tdk.src.gateway 100%
core.main.src.firebolt.handlers 2%
core.main.src.bootstrap.manifest 0%
core.main.src.firebolt 1%
core.main.src.state 21%
core.launcher.src.manager 7%
device.mock_device.src 12%
core.sdk.src 100%
core.main.src.processor 0%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.events 4%
core.main.src 6%
core.main.src.processor.storage 0%
device.thunder_ripple_sdk.src.processors.events 0%
core.sdk.src.api.gateway 51%
core.sdk.src.api.firebolt 47%
core.sdk.src.api 68%
core.main.src.service 30%
core.main.src.broker 23%
Summary 26% (8099 / 31278)

Minimum allowed line rate is 20%

Current coverage:26% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch.

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ satlead
❌ kpears201
❌ adamdama
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants