Cleanup JS code, added Docker configuration, added read example #9
Conversation
| "node": ">=14.4.0" | ||
| }, | ||
| "dependencies": { | ||
| "@grpc/grpc-js": "^1.4.4", |
There was a problem hiding this comment.
Is there any particular reason to use GRPC? If not, let's add an issue to get rid of it.
There was a problem hiding this comment.
It's required for gRPC communication. There are a few compatible variants available like grpc and grpc-web.
There was a problem hiding this comment.
but do we need to do any gRPC communication? Are we doing anything that's not available via the web api?
There was a problem hiding this comment.
We are only using gRPC without any HTTP connection to the node.
src/chain_replica.mjs
Outdated
| password: 'REPLACE_WITH_SECURE_POSTGRES_PASSWORD', | ||
| password: process.env.POSTGRES_PASSWORD, |
|
|
||
| // Load .env file | ||
| import { config } from 'dotenv'; | ||
| config(); |
There was a problem hiding this comment.
I don't have any nice solution for this. dotenv uses fs and path directly and I didn't find some more SES compatible variant.
Do you have any suggestions? Is it possible to use SES shim to load it inside separate Compartment with provided fs and path as only global variables?
There was a problem hiding this comment.
... dotenv uses fs and path directly ...
yeah; that's a bug. reimplementing dotenv with ocap discipline is probably about 20 lines of code. But it can wait for a later PR.
There was a problem hiding this comment.
Is it possible to use SES shim to load it inside separate Compartment with provided fs and path as only global variables?
Yes, that can work too, if you really have to use 3rd party code and you can't change it.
There was a problem hiding this comment.
yeah; that's a bug. reimplementing dotenv with ocap discipline is probably about 20 lines of code. But it can wait for a later PR.
👍 I wonder should it be update of existing lib or a new package?
I tried to import dotenv in isolated Compartment.
import 'ses';
lockdown();
const c = new Compartment({fs, path});
const r = c.evaluate(`
import { config } from 'dotenv';
config();
`);But I see this error:
(SyntaxError#1)
SyntaxError#1: Cannot use import statement outside a module
at Object.eval (eval at makeEvaluateFactory (file:///home/tomi/projects/rchain/rchat/node_modules/ses/dist/ses.umd.js:1400:10), <anonymous>:8:30)
There was a problem hiding this comment.
should it be update of existing lib or a new package?
I would probably just add a .js file in this project.
There was a problem hiding this comment.
Cannot use import statement outside a module
right... your browser will tell you the same thing if you try to eval an import declaration.
To load modules into a Compartment, you have to use @endo/compartment-mapper. Either importLocation or writeArchive followed by importArchive, I think. I asked for clarification in endojs/endo#963
There was a problem hiding this comment.
Issue to track updates #12.
|
|
||
| // Load .env file | ||
| import { config } from 'dotenv'; | ||
| config(); |
| console.log(`Copy URI to .env file IDDB_CONTRACT_URI variable.`); | ||
| }; | ||
|
|
||
| await main(process.env, {fs, grpcLib}); |
There was a problem hiding this comment.
yay for passing process.env explicitly.
|
|
||
| // Load .env file | ||
| import { config } from 'dotenv'; | ||
| config(); |
src/iddb.rho
Outdated
| loop!(rest, acc.put(target, record)) | ||
| loop!(rest, acc.set(target, record)) |
There was a problem hiding this comment.
ugh. I clearly never tested this.
Bonus points for updating the "unit test" stuff below to exercise this code.
There was a problem hiding this comment.
Kudos for having only one error without testing it. :)
src/rnode-env.mjs
Outdated
| @@ -94,3 +99,18 @@ function makeGetDeployResult({ deployService }) { | |||
| return listenData; | |||
| }; | |||
| } | |||
|
|
|||
| /** | |||
| * @param {Object} arg | |||
There was a problem hiding this comment.
What you mean by io in this context?
There was a problem hiding this comment.
I mean:
| * @param {Object} arg | |
| * @param {Object} io |
deployService is a form of IO. Most powerful stuff that we pass around is.
There was a problem hiding this comment.
OK, I can see your perspective as argument that can serve IO operations. I'm looking more as function input arguments.
|
|
||
| // Load .env file | ||
| import { config } from 'dotenv'; | ||
| config(); |
Overview
This PR clean-up the JS code with RNode client helper which is used in all scripts to setup Rholang contracts for on-chain DB and runner which exports messages from Zulip.
Docker-compose configuration for RNode and Zulip and
.envfile are added to the project to make it easier to run.Script tasks are moved from Make file to npm scripts for easier control and less OS dependency.
Added example script to read tables, keys and messages from on-chain DB.
Root README file is updated with instructions how to run the whole process. README file inside src related to detailed information about Zulip connection and DB triggers is not updated.