Dev #5
Open
Dev #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick and dirty fixes ^_^
Quick and dirty fixes ^_^
Quick and dirty fixes ^_^
Quick and dirty fixes ^_^
Yosemite Beta 2 Compatibility
UUID for Beta 3
Fixed some minor things and renamed the file to be more standard. Commit from felixphew.
added link to transifex to prevent users from sending pull requests for localizations via github
[#752 state:fixed assigned:mento]
GPGMail may doesn’t work as expected. -> GPGMail is not working as expected.
[FIX] more width in GPGMail preferences window for localization strings and „Check Now“ Button
…ntinued [#760 state:fixed] [#692 state:fixed] - Already decides whether or not to encrypt a draft in [ComposeBackEnd makeMessageWithContents:isDraft:shouldSign:shouldEncrypt:shouldSkipSignature:shouldBePlainText:] - Saves the current sign and encrpyt status as messages headers, in order to restore them later.
…y the user [#761 state:fixed]
…[#747 state:fixed] - This only seems to occur if the message is to be encrypted and saved as a draft so the duplicated headers are only removed in that case.
…essage upon sending [#762 state:fixed]
improved many error messages fixed http https confusion for website / support site [#652 state:fixed assigned:steve milestone:2.1.1]
Conflicts: Resources/Info.plist
type fixed
…fied PGP/MIME (El Capitan)[#921] - If more than one application/pgp-encrypted part is detected check each for the PGP/MIME version marker. Previously only the first one was checked for the PGP/MIME version marker.
…#924 state:fixed] - Adjust PGP regex to allow whitespace before and between new line characters. As well as after the PGP start marker.
… been saved again as normal PGP/MIME messages [#866 state:fixed]
- When a user continues composing a draft, the draft should always be automatically
decrypted, so that the detail that the draft is encrypted is invisible to the user.
Under some circumstances, the automated decryption of the draft fails.
If at the same time Mail's autosave of drafts kicks in, the still encrypted draft,
is saved again as a multipart/related message with a text/html part for the actual contents
and two attachments: the PGP/MIME application/pgp-encrypted version part and the encrypted.asc
data part.
Now if the user tries to continue working on the draft, GPGMail no longer recognizes
the draft as PGP/MIME encrypted, and fails to properly decrypt it.
- The solution is to teach GPGMail the structure of those falsely encrypted not automatically decrypted
drafts, in order to recognize that it should still treat them as normal PGP/MIME encrypted messages.
In order to do that, the following facts have to be true:
- Must have a multipart/related part
- Must have an application/pgp-encrypted attachment
- Must have an application/octet-stream attachment with filename set to encrypted.asc
User ID → user ID
The compose settings are obviously about defaults so removed „by default“ from the strings
The compose settings are obviously about defaults so removed „by default“ from the strings
E-Mail → Email
This reverts commit 6b337b5.
E-Mail → Email
occured → occurred
SignatureView and AttachmentView.
Code singing doesn't allows extended attributes.
Do not show unnecessary informations. Show subkey fingerprint. Always show details. When there is a single signature, hide signatures list. [FIX] Do not show mangled attachment details in some circumstances.
…-signed PGP message - If a bad or missing MDC is detected, don’t display the decrypted content. - Display a proper error message for MDC errors. [#980 state:fixed] [fix]
[#980] [fix]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.