Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): clarify that PDFs are not supported #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

si-net
Copy link

@si-net si-net commented Oct 4, 2024

No description provided.

@si-net si-net changed the title Make it clear that PDFs are not supported docs(readme): Make it clear that PDFs are not supported Oct 4, 2024
@rbardini rbardini changed the title docs(readme): Make it clear that PDFs are not supported docs(readme): clarify that PDFs are not supported Oct 6, 2024
@rbardini rbardini added the documentation Improvements or additions to documentation label Oct 6, 2024
@rbardini
Copy link
Owner

rbardini commented Oct 6, 2024

Thanks, @si-net! Could you please run Prettier on the README? It's failing the format-check step.

I'm actually exploring PDF support in main...add-pdf-format-support, but for now the FAQ will be helpful.

@si-net
Copy link
Author

si-net commented Oct 7, 2024

I ran prettier locally, no errors

I tired to add the --write option to your pipeline, so you actually see what it complains about, but I could not find the correct place to add it, Its not an explicit stage in your actions, and seems to be part of the npm built process.

Good to know that you are working on pdf support, thank you!

In the meantime I think the way to go is to actually use json-resume themes, that are built with pdf-support in mind.

Many of the themes out there will just never fit on one page, so even when exporting them, you don't gain much. Seems to me like the way to go is with changing the themes so that they are ready for pdf.

@rbardini
Copy link
Owner

rbardini commented Oct 9, 2024

You can run npm run format -- --write to format all files. Looks like there's a trailing space at the end of a heading and an extra line at the bottom of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants