Merge pull request #10 from razorpay/resolve-progress

Resolve progress

README.md

@@ -812,6 +812,16 @@ The result should be a new PR on the Pongo repo.
 
 ---
 
+## unreleased
+
+* Fix: `pongo down` would not remove volumes. This
+  caused orphaned volumes on long running VMs as well as on personal
+  machines.
+* Fix: drop the `--progress` flag from docker commands when building. Since
+  the flag isn't always available.
+
+---
+
 ## 2.7.0 released 7-Jul-2023
 
 * Feat: Kong Enterprise 2.8.4.2, which means that Pongo 2.x will support the

pongo.sh

@@ -365,7 +365,7 @@ function parse_args {
           args_done=1
           ;;
         --debug)
-          PONGO_DEBUG=true
+          # PONGO_DEBUG=true
           set -x
           ;;
         *)
@@ -713,15 +713,16 @@ function build_image {
   fi
 
   msg "starting build of image '$KONG_TEST_IMAGE'"
-  local progress_type
-  if [[ "$PONGO_DEBUG" == "true" ]] ; then
-    progress_type=plain
-  else
-    progress_type=auto
-  fi
+  # local progress_type
+  # if [[ "$PONGO_DEBUG" == "true" ]] ; then
+  #   progress_type=plain
+  # else
+  #   progress_type=auto
+  # fi
+  # The following line caused issues on newer Docker releases, so we're disabling it for now
+  # --progress $progress_type \
   $WINPTY_PREFIX docker build \
     -f "$DOCKER_FILE" \
-    --progress $progress_type \
     --build-arg PONGO_VERSION="$PONGO_VERSION" \
     --build-arg http_proxy \
     --build-arg https_proxy \