Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FileUpload): add onReupload prop in case of error state #2201

Merged
merged 6 commits into from
May 29, 2024

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 27, 2024

Description

  • Slack thread
  • Added onReupload prop, to be used in case of error state.

Changes

Screen.Recording.2024-05-29.at.11.16.24.AM.mov

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented May 27, 2024

🦋 Changeset detected

Latest commit: d628bce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 27, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented May 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d628bce:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented May 27, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
FileUpload 14.547 16.882 +2.335 KB

Generated by 🚫 dangerJS against d628bce

@snitin315 snitin315 changed the title feat(FileUpload): error state UX enhancements feat(FileUpload): add onRetry prop in case of error state May 28, 2024
@snitin315 snitin315 marked this pull request as ready for review May 28, 2024 05:22
@anuraghazra
Copy link
Member

The UX seems a bit odd, ideally clicking retry should directly try to reupload the same file which is already selected but instead it's opening the file picker again and asking consumers to select the same file again.

@snitin315 snitin315 changed the title feat(FileUpload): add onRetry prop in case of error state feat(FileUpload): add onReupload prop in case of error state May 28, 2024
@snitin315 snitin315 force-pushed the feat/file-upload-enhancements branch from dc1143a to 2b63ec5 Compare May 28, 2024 11:21
@snitin315
Copy link
Member Author

snitin315 commented May 29, 2024

The UX seems a bit odd, ideally clicking retry should directly try to reupload the same file which is already selected but instead it's opening the file picker again and asking consumers to select the same file again.

We decide to update the wording to Re-upload

@snitin315 snitin315 closed this May 29, 2024
@snitin315 snitin315 reopened this May 29, 2024
@snitin315 snitin315 merged commit 2a4d167 into master May 29, 2024
23 checks passed
@snitin315 snitin315 deleted the feat/file-upload-enhancements branch May 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants