Add Reporter class for Newrelic abstraction and job utility #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Shouldn't have specific attributes like review id articles count. Deprecate the report function. |
OAbubakr
approved these changes
Dec 20, 2023
Done. |
hammady
added a commit
that referenced
this pull request
Dec 20, 2023
* Decouple Worker class from Newrelic using new Reporter class * Add new Reporter class to abstract Newrelic reporting * Inject reporter into job from worker * Test multiple python versions using GH actions
hammady
added a commit
that referenced
this pull request
Dec 21, 2023
* Instrument using custom attributes + add Worker tests (#18) * Add tests to the Job class (#19) * Add support for reporting extra fields if configured (#20) * Add Reporter class for Newrelic abstraction and job utility (#21) * Fix integration bugs + add report_raw and flatten dicts (#23) * Patch GH action to work on python 2.7 only * Downgrade pytest, PyYAML, psycopg2-binary to work with python 2.7 * Fix tests and job to be python 2.7 compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporterwhich abstracts away all implementation details for the Newrelic agent from theWorkerclass..reporter.report(**attributes).Workerclass, you can configure all custom reported attributes to have a common prefix using the new parameter:reported_attributes_prefix.