Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pod disruption budget #114

Closed
wants to merge 5 commits into from
Closed

Conversation

punit-kulal
Copy link
Contributor

Added support for three fields

  1. enabled: Default false for backward compatibility
  2. minAvailable: Default 0 default value doesn't actually impact anything
  3. maxUnavailable: No default value.

@punit-kulal punit-kulal self-assigned this Jul 30, 2024
@@ -15,4 +15,4 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.5.4
version: 0.5.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a new feature, shouldn't we bump "minor"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous additions also bumped the patch version.
I am okay with either.
Will bump to 0.6.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah !

@whoAbhishekSah
Copy link
Member

@punit-kulal rebase on main !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants