Add delete_many functionality to object store #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghumdani
reviewed
Oct 2, 2024
raghumdani
reviewed
Oct 3, 2024
raghumdani
reviewed
Oct 3, 2024
raghumdani
reviewed
Oct 3, 2024
raghumdani
reviewed
Oct 3, 2024
| @@ -365,6 +367,9 @@ def _run_hash_and_merge( | |||
| mutable_compaction_audit.set_telemetry_time_in_seconds( | |||
| telemetry_this_round + previous_telemetry | |||
| ) | |||
| if params.num_rounds > 1: | |||
There was a problem hiding this comment.
Can we add an e2e functional test using a Test object store impl to test this behavior?
There was a problem hiding this comment.
I don't see e2e functional test.
There was a problem hiding this comment.
Added an assertion to our multiple rounds test, it checks that delete_many was called
There was a problem hiding this comment.
No, I am looking for an assertion. Add an e2e test with multiple rounds that ensures object ends up clean after compaction.
raghumdani
reviewed
Oct 4, 2024
| @@ -327,4 +328,5 @@ def test_compact_partition_rebase_multiple_rounds_same_source_and_destination( | |||
| if assert_compaction_audit: | |||
| if not assert_compaction_audit(compactor_version, compaction_audit): | |||
| assert False, "Compaction audit assertion failed" | |||
| assert object_store_delete_many_spy.call_count, "Object store was never cleaned up!" | |||
There was a problem hiding this comment.
This just checks if delete_many was called. We want to test behavior i.e., the object store actually ends up with no data after the compaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
delete_manyfunctionality to object stores. This is necessary to cleanup the object store between rounds of compaction.