Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr workflow automation poc #74

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

raulcd
Copy link
Owner

@raulcd raulcd commented Feb 6, 2023

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@raulcd raulcd marked this pull request as draft February 7, 2023 12:05
@raulcd raulcd added bug Something isn't working and removed bug Something isn't working labels Feb 9, 2023
Copy link

@fontim fontim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comment review body message

- opened
- converted_to_draft
- ready_for_review
pull_request_review:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comment

@raulcd raulcd force-pushed the pr-workflow-automation-poc branch 2 times, most recently from 413c899 to a166340 Compare February 10, 2023 16:47
Copy link

@fontim fontim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new review from non-committer

Copy link

@fontim fontim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review as collaborator

Copy link
Owner Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review as committer

Copy link
Owner Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

raulcd added a commit to apache/arrow that referenced this pull request Feb 28, 2023
### Rationale for this change

As discussed on the [mailing list](https://lists.apache.org/thread/1rhsd8ovy4bfr8hcdohn0vh65frw0ggk) is quite difficult to understand the current state of a PR whether it requires further review, it has gone stale or new changes have been added. This allows us to have a set of labels based on the state of the PR.

```mermaid
flowchart TD
    A([New PR]):::creator
    A -- by non-committer --> B[Awaiting review]:::anyone
    A -- by committer --> C[Awaiting commiter review]:::committer
    B & C -- new review by\nanother non-committer --> C
    C & B & E  -- new committer review\nrequests changes --> D[Awaiting changes]:::creator
    D -- changes by creator --> E[Awaiting change review]:::committer
    C & E & B -- new committer review\napproves ---> F[Awaiting merge]:::committer
classDef creator stroke:#CC0;
classDef anyone stroke:#00C;
classDef committer stroke:#0C0;
classDef triager stroke:#C0C;
linkStyle 0,1,7 stroke:#CC0,color:auto;
linkStyle 2,3 stroke:#00C,color:auto;
linkStyle 4,5,6,8,9,10 stroke:#0C0,color:auto;
```
### What changes are included in this PR?

New workflow to trigger archery bot on the required actions. New PR Workflow bot implementation on archery that manages the GitHub events and state.
New fixtures and tests.

### Are these changes tested?

There are unit tests and has been tested on my fork. Some transition examples on this PR:
raulcd#74

* Closes: #33977

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants