Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rmm::percent_of_free_device_memory in arena test #1689

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Use rmm::percent_of_free_device_memory in arena test #1689

merged 1 commit into from
Sep 30, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Sep 30, 2024

Description

Rather than hand-coding a fraction of the device memory use the utility routine.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Use percent_of_free_device_memory in arena test
f93e235 
Rather than hand-coding a fraction of the device memory use the
utility routine.

- Closes rapidsai#1674
@wence- wence- added tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general non-breaking Non-breaking change labels Sep 30, 2024
@wence- wence- requested a review from a team as a code owner September 30, 2024 11:18
@github-actions github-actions bot added the cpp Pertains to C++ code label Sep 30, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function and removed cpp Pertains to C++ code labels Sep 30, 2024
@wence-
Copy link
Contributor Author

wence- commented Sep 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9e410c0 into rapidsai:branch-24.12 Sep 30, 2024
57 checks passed
@wence- wence- deleted the wence/fix/1674 branch September 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use rmm::percent_of_free_device_memory in arena_mr_tests
2 participants
@wence- @rongou