Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fmt (to 11.0.2) and spdlog (to 1.14.1). #1678

Merged
merged 20 commits into from
Sep 23, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 11, 2024

Contributes to:

Replaces #1544

Now that most of conda-forge has been updated to fmt >=11.0.1,<12 and spdlog>=1.14.1,<1.15 (rapidsai/build-planning#56 (comment)), we're attempting to upgrade RAPIDS to similar versions of those libraries.

This impoves the likelihood that RAPIDS will be installable alongside newer versions of its dependencies and complementary packages on conda-forge.

Notes for Reviewers

This PR is testing changes made in rapidsai/rapids-cmake#689.
It shouldn't be merged until those rapids-cmake changes are merged and any testing-specific details have been removed.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 11, 2024
@github-actions github-actions bot added the conda label Sep 11, 2024
@github-actions github-actions bot added the CMake label Sep 11, 2024
dependencies.yaml Outdated Show resolved Hide resolved
conda/recipes/librmm/conda_build_config.yaml Outdated Show resolved Hide resolved
include("${rapids-cmake-dir}/export/find_package_root.cmake")
rapids_export_find_package_root(BUILD spdlog [=[${CMAKE_CURRENT_LIST_DIR}]=]
EXPORT_SET rmm-exports)
endif()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context for these get_spdlog.cmake changes: rapidsai/rapids-cmake#387 (comment)

rapids_config.cmake Outdated Show resolved Hide resolved
@jameslamb jameslamb added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 19, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] Update fmt (to 11.0.2) and spdlog (to 1.14.1). Update fmt (to 11.0.2) and spdlog (to 1.14.1). Sep 19, 2024
@jameslamb jameslamb marked this pull request as ready for review September 19, 2024 16:51
@jameslamb jameslamb requested review from a team as code owners September 19, 2024 16:51
@jameslamb jameslamb requested review from msarahan, bdice and KyleFromNVIDIA and removed request for msarahan September 19, 2024 16:51
@jameslamb jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 23, 2024
@AyodeAwe AyodeAwe merged commit 99e237e into rapidsai:branch-24.10 Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants