Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing include to resource_ref.hpp #1677

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add missing include to resource_ref.hpp #1677

merged 1 commit into from
Sep 10, 2024

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Sep 10, 2024

This has been found breaking CCCL CI when building cuDF

@miscco
Add missing include to resource_ref.hpp
56b69a9 
This has been found breaking CCCL CI when building cuDF
@miscco miscco requested a review from a team as a code owner September 10, 2024 08:27
@github-actions github-actions bot added the cpp Pertains to C++ code label Sep 10, 2024
@miscco
Copy link
Contributor Author

miscco commented Sep 10, 2024

See e.g https://github.com/NVIDIA/cccl/actions/runs/10788009285/job/29917862663?pr=2392

@miscco miscco added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Sep 10, 2024
wence-
wence- approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

harrism
harrism approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I only just
Merged this today.

@harrism
Copy link
Member

harrism commented Sep 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit 800dc87 into rapidsai:branch-24.10 Sep 10, 2024
57 checks passed
@miscco
Copy link
Contributor Author

miscco commented Sep 10, 2024

Good catch, I only just Merged this today.

I really like the fact that such issues can be found fast due to our CI

@miscco miscco deleted the fix_missing_include_resource_ref branch September 10, 2024 09:00
@harrism
Copy link
Member

harrism commented Sep 10, 2024

Well, good CI would catch it in the PR! I wonder why it wasn't? I guess our tests only include that header after error.hop

@bdice
Copy link
Contributor

bdice commented Sep 10, 2024

This was also caught in the cudf nightly CI here: https://github.com/rapidsai/cudf/actions/runs/10786473351/job/29932807806

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@wence- wence- wence- approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miscco @harrism @bdice @wence-