Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Build C++ wheel (#2264)"" #2306

Draft
wants to merge 1 commit into
base: branch-24.06
Choose a base branch
from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 10, 2024

Reverts #2305

Opening this preemptively for tracking, but no plans to try and merge this for a while (see rapidsai/build-planning#33 (comment)).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.27%. Comparing base (d11e78a) to head (d121816).
Report is 3 commits behind head on branch-24.06.

Files Patch % Lines
python/pylibraft/pylibraft/__init__.py 66.66% 2 Missing ⚠️
python/raft-dask/raft_dask/__init__.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           branch-24.06    #2306   +/-   ##
=============================================
  Coverage         87.27%   87.27%           
=============================================
  Files                25       25           
  Lines               550      550           
=============================================
  Hits                480      480           
  Misses               70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Iterate over the array
for wheelhouse in "${WHEELHOUSES[@]}"; do
FIND_LINKS+="--find-links ${wheelhouse} "
done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever we pick this back up, I think it'd be preferable to switch away from FIND_LINKS towards a constraint file, as described in rapidsai/build-planning#69 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants