Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable warnings as errors for Python tests #2288

Merged
merged 4 commits into from
May 8, 2024
Merged

Enable warnings as errors for Python tests #2288

merged 4 commits into from
May 8, 2024

Conversation

mroeschke
Copy link
Contributor

As part of rapidsai/build-planning#26, warnings in Python tests will be converted to test failures

ignore:Unknown pytest.mark.ucx:PytestUnknownMarkWarning could be removed once #2281 is merged cc @jameslamb

@mroeschke mroeschke requested a review from a team as a code owner May 2, 2024 21:59
@github-actions github-actions bot added the python label May 2, 2024
@mroeschke mroeschke mentioned this pull request May 2, 2024
Open
@jameslamb
Copy link
Member

Thanks for the @.

I didn't even think about how this work you're doing would have caught the thing I just happened to notice in logs that led to #2281... nice!!

@rapidsai/raft-python-codeowners #2281 is small and I think non-controversial, it's ready for review.

mroeschke
mroeschke commented May 3, 2024
View reviewed changes
python/raft-dask/pytest.ini Outdated Show resolved Hide resolved
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2024
dantegd
dantegd approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjnolet
Copy link
Member

cjnolet commented May 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4c1bf03 into rapidsai:branch-24.06 May 8, 2024
69 checks passed
@mroeschke mroeschke deleted the tst/wae branch May 8, 2024 16:33
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
@mroeschke @abc99lr
Enable warnings as errors for Python tests (rapidsai#2288)
5dfb555 
As part of rapidsai/build-planning#26, warnings in Python tests will be converted to test failures


`ignore:Unknown pytest.mark.ucx:PytestUnknownMarkWarning` could be removed once rapidsai#2281 is merged cc @jameslamb

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#2288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @jameslamb @cjnolet @dantegd